Skip to content

chore: tests for compute_script#294

Merged
dsherret merged 4 commits into
denoland:mainfrom
dsherret:tests_compute_script
Apr 8, 2025
Merged

chore: tests for compute_script#294
dsherret merged 4 commits into
denoland:mainfrom
dsherret:tests_compute_script

Conversation

@dsherret

@dsherret dsherret commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@dsherret dsherret marked this pull request as ready for review April 8, 2025 17:22
@dsherret dsherret requested a review from nathanwhit April 8, 2025 17:22
Comment thread src/parsed_source.rs
self.program_ref().compute_is_script()
} else {
matches!(self.program_ref(), ProgramRef::Script(_))
}

@dsherret dsherret Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight perf improvement for non-typescript sources.

@nathanwhit nathanwhit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants